[Ohrrpgce] SVN: james/9374 Add FlexmenuCaptionBrowser which is automatically used in a bunch of pla

[Ralph Versteegen]

But that's an extra line of code! :P

On 16 September 2017 at 02:35, James Paige <Bob at hamsterrepublic.com> wrote:

> Yes, I think you are right.
>
> Some single-use lists will actually have a reason to be separate classes,
> but the ones I have implemented so far don't have any such reason.
>
> I'll probably go with a .set_array() method, rather than a constructor,
> since that seems a little more readable, and a little more flexible
>
> I'll change those as soon as I have time.
>
>
>
> On Fri, Sep 15, 2017 at 5:13 AM, Ralph Versteegen <teeemcee at gmail.com>
> wrote:
>
>> I'm impressed  - I didn't think flexmenu would show some flexibility! :)
>> flexmenu does at least get the focus on data right, just not how you
>> provide the data!
>>
>> I'm not a fan of creating a separate class for every array of constants,
>> even if it's only 6 lines of code each time, if that class is only going to
>> be used in one place. Why not just have a generic class which allows
>> passing a list of strings to its constructor (or other method)? That way it
>> can work even if the array isn't global.
>> Likewise, I imagine that once we have a new spriteset system and
>> animations almost all the differences between different sprite types will
>> disappear, even backdrops. (All sprite browsers should scale down huge
>> sprites)
>> But I notice that attacks always animate, while everything else only
>> animates when selected. Is that intentional?
>>
>> On 15 September 2017 at 10:17, <subversion at hamsterrepublic.com> wrote:
>>
>>> james
>>> 2017-09-14 15:17:29 -0700 (Thu, 14 Sep 2017)
>>> 245
>>> Add FlexmenuCaptionBrowser which is automatically used in a bunch of
>>> places in the Attack editor and Enemy editor
>>> (I think I can honestly say this is the first time in more than 10 years
>>> that doing a thing in the flexmenu code has been pleasant)
>>> ---
>>> U   wip/attackedit.bas
>>> U   wip/thingbrowser.bas
>>> U   wip/thingbrowser.bi
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>>
>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>>
>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20170916/609e0306/attachment-0001.html>