[Ohrrpgce] SVN: teeemcee/9567 Slice editor now enforces mutual exclusion of Cover and Fill, and disabl

Ralph Versteegen teeemcee at gmail.com
Tue Oct 10 08:45:34 PDT 2017


It feels like they got repurposed for something other than the reason they
were originally added - as evidenced by the name, which only makes much
sense for things like the X and Y setting, which are a group which can also
be edited together. It's confusing that there's a parallel set of rule.mode
constants, eg erIntgrabber, with sometimes the rule.mode handling
enter_space_click, and sometimes the rule.group handler, but I guess
there's a valid reason for it. And the I made it worse by adding a third
parallel track, slice_edit_updates.
Not easy to see how to make it cleaner, though. Maybe just not putting all
the logic in one function.

A large part of the problem is that the slice editor bypasses the
accessor/mutator functions in slices.bas, like ChangeRectSlice, so has to
reimplement all that logic (and generally fails to match it). And that safe
mutator functions don't exist for a lot of the complex stuff anyway (eg
fill mode)


On 11 October 2017 at 03:36, James Paige <Bob at hamsterrepublic.com> wrote:

> The rule groups were probably a bad idea. ;)
>
>
> On Tue, Oct 10, 2017 at 7:11 AM, <subversion at hamsterrepublic.com> wrote:
>
>> teeemcee
>> 2017-10-10 07:11:13 -0700 (Tue, 10 Oct 2017)
>> 183
>> Slice editor now enforces mutual exclusion of Cover and Fill, and
>> disables Cover when disallowed or trying to resize
>>
>> I'm finding slice_edit_updates more convenient then 'rule groups'
>> ---
>> U   wip/sliceedit.bas
>> U   wip/slices.bas
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>
>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20171011/5d4f27e0/attachment-0001.html>


More information about the Ohrrpgce mailing list