[Ohrrpgce] SVN: teeemcee/8023 Fix/refactor RELOAD VLI implementation to support negative and 64bit int

James Paige Bob at HamsterRepublic.com
Sun May 22 07:48:46 PDT 2016


So we really had no negative VLIs in any documents? I had (mistakenly?)
assumed that *all* integers in reload were VLI

On Sunday, May 22, 2016, <subversion at hamsterrepublic.com> wrote:

> teeemcee
> 2016-05-22 02:28:28 -0700 (Sun, 22 May 2016)
> 769
> Fix/refactor RELOAD VLI implementation to support negative and 64bit ints;
> add lots of testcases.
>
> -Encoding of negative numbers was completely broken due to a typo
>  (This typo produced a compiler warning when compiling with -gen gcc!)
>  However RELOAD files do not contain negative VLI numbers
> -ReadVLI only supported 32 bit ints, returning wrong answer otherwise
>  (except in 64 bit builds)
> -I have changed the encoding of negative numbers. Now the bitwise
>  complement is stored rather than the negation. This allows
>  -2^63 to be encoded. No change to the RELOAD version number is necessary.
> -Read/WriteVLI were duplicated for two different types of file
> input/output,
>  so I combined them by using macros
> -Testcases check that all these functions give expected results.
> ---
> U   wip/reload.bas
> U   wip/reload.bi
> U   wip/reloadtest.bas
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org <javascript:;>
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20160522/2abef461/attachment.htm>


More information about the Ohrrpgce mailing list