[Ohrrpgce] SVN: teeemcee/6380 If a hero was weak, attack animations didn't occur (they were overridden

subversion at HamsterRepublic.com subversion at HamsterRepublic.com
Fri Feb 7 01:02:57 PST 2014


teeemcee
2014-02-07 01:02:57 -0800 (Fri, 07 Feb 2014)
617
If a hero was weak, attack animations didn't occur (they were overridden).

This was introduced in r5557, the fix for ancient bug 75: Incorrect animation
when running away while weak.
The message for that revision was mistaken:
- bat.acting is battle slot ID, not hero ID+1 as stated.
  You have to tell from context (bat.atk.id apparently)
  whether bat.acting is garbage. Also, it's not 0 when running away
- The check should actually have been there afterall, but it was buggy
  (affected by garbage bat.acting)

However, maybe the whole line could be removed entirely.

All code for setting .frame is pretty dodgy
---
U   wip/battle_udts.bi
U   wip/bmod.rbas
U   wip/whatsnew.txt


More information about the Ohrrpgce mailing list