[Ohrrpgce] SVN: james/5080 Fix broken slice mutators. slices.bas compiles again now

[James Paige]

On Tue, Feb 28, 2012 at 09:04:21AM -0800, subversion at HamsterRepublic.com wrote:
> james
> 2012-02-28 09:04:21 -0800 (Tue, 28 Feb 2012)
> 57
> Fix broken slice mutators. slices.bas compiles again now
> ---
> U   wip/slices.bas

I have several thoughts about these accessors and mutators.

the OHR code is riddled with crazy naming schemes and inconsistent 
style, but slices.bas is wone of the few files that is well organized 
and consistently style, so it would be nice to keep it that way.

What I notice especially is that all the existing slice related 
functions all take the Slice ptr as the first argument. I would like it 
if these new slice mutator functions would do the same.

There are other style issues like spaces instead of tabs, or names in 
the form of SomethingSomethingSlice() instead of 
sliceSomethingSomething() but those are of much less importance to me 
than the argument order.

I was also thinking about null ptr checking. Most of the other slice 
functions do explicit null ptr checking. In the past, this was a really 
big deal for me because null ptr bugs used to be INSANELY frustrating to 
debug. However, now that we can run in gdb, and use valgrind (and now 
that I know how to do both of those things) I guess I don't have to be 
the same stickler for null ptr checking that I used to be...

---
James Paige