[Ohrrpgce] SVN: james/5025 Replace hardcoded instances of 4095 (and one 4096) with the new const ma

[Ralph Versteegen]

On 9 February 2012 03:50, James Paige <Bob at hamsterrepublic.com> wrote:
> On Wed, Feb 08, 2012 at 07:53:15PM +1300, Ralph Versteegen wrote:
>> On 8 February 2012 15:19,  <subversion at hamsterrepublic.com> wrote:
>> > james
>> > 2012-02-07 18:19:44 -0800 (Tue, 07 Feb 2012)
>> > 402
>> > Replace hardcoded instances of 4095 (and one 4096) with the new const maxScriptGlobals
>> > Taking care to only update the ones that are actually relevant to globals ;)
>> >
>> > There is one 4095 in customsubs.bas in cond_grabber()
>> > that I was a little puzzled about, so I left it unchanged with a comment,
>> > I would appreciate it if you could take a look at it, tmc, since you
>> > know cond_grabber so much better than I
>>
>> The "future proofing" refers to raising the maximum tag number above
>> (max global) 4095 in the future. Conditions can test global variable
>> values (not used anywhere yet, of course ... I think).
>>
>
> I am still confused about how the max global relates to the max tag
>
> ---
> James

When you change the type of condition from a tag condition to a global
variable condition, the ID number is preserved. Which I guess is
actually pretty pointless. And anyway, the UI needs a rework:
yesterday I couldn't immediately remember that you have to press the
Tab key to switch between editing the global variable ID and the
threshold. There's no reason that the left/right keys need to be
reserved for incrementing and decrementing.