[Ohrrpgce] SVN: teeemcee/5032 Add Formation UDT and loading+saving code and use it throughout bmod

[James Paige]

On Thu, Feb 09, 2012 at 01:44:40AM +1300, Ralph Versteegen wrote:
> On 9 February 2012 01:26,  <subversion at hamsterrepublic.com> wrote:
> > teeemcee
> > 2012-02-08 04:26:43 -0800 (Wed, 08 Feb 2012)
> > 68
> > Add Formation UDT and loading+saving code and use it throughout bmod
> > ---
> > U   wip/battle_udts.bi
> > U   wip/bmod.bas
> > U   wip/bmod.bi
> > U   wip/bmodsubs.bas
> > U   wip/bmodsubs.bi
> > U   wip/loading.bas
> > U   wip/loading.bi
> > U   wip/subs.bas
> > U   wip/udts.bi
> 
> Aside, I just noticed that the Formation UDT and the formation SUB
> have the same name, no warning at all. I hadn't realised that these
> inhabit total different namespaces.
> 
> Currently rewriting the formation editor; that one literally brought
> tears to my eyes. It has it all: two completely different menus
> sharing the same loop with some big IF blocks, a profusion of single
> letter variable names, FIVE! different cursor variables (pt, csr,
> bcsr, csr2, csr3) putting anything in menustuf.bas to shame, negative
> array starting indices, xintgrabber and zintgrabber, a dozen GOSUBs, a
> reimplementation of standardmenu, multiple IF statements on one line,
> a hundred-odd magic constants, and Mike's lovely explanation of the
> off-by-ones in the max() array. Well, at least it doesn't have
> inconsistent indentation

You are a brave, brave man, and I salute you! :)

---
James