[Ohrrpgce] Anything else for Ypsiliform+3?

[Ralph Versteegen]

On 29 October 2010 06:28, James Paige <Bob at hamsterrepublic.com> wrote:
> On Fri, Oct 29, 2010 at 06:19:02AM +1300, Ralph Versteegen wrote:
>> On 29 October 2010 06:00, James Paige <Bob at hamsterrepublic.com> wrote:
>> > I went through the wip subversion log and backported everthing that
>> > seemed be all three of siple, safe, and important and backported
>> > them to the ypsiliform branch.
>> >
>> > Essentially, I picked all the low-hanging fruit.
>> >
>> > Does anybody else see anything else that looks worth the trouble to
>> > backport?
>> >
>> > ---
>> > James
>>
>> Looks fine to me. Hopefully Zenzizenic will release fairly soon, so we
>> don't need to worry too much about it.
>>
>> Originally when we were going to release Ypsiliform+3, I wanted to
>> include the new version of HSpeak plus the improved script error line
>> reporting. But now I'd rather put that off since at least one bug was
>> introduced, and I'm going to revert that filename quoting stuff. Or
>> rather, I did so 6 months ago but never committed :P
>>
>>     * Music and sound effects can be previewed everywhere in
>>       Custom by hitting Enter [Ralph]
>>
>> That's a bugfix?
>
> No, but it was a safe useful low-impact easy-to-test feature, so I
> figured "why not?"
>
> The only thing I noticed that I kinda wanted to backport but didn't was
> the unix fix for opening an rpgdir on a different filesystem from your
> home direcotory. The patch didn't apply cleanly, and I was a little wary
> of hand editing it without a better understanding of it.
>
> ---
> James

That one's quite simple if you remove the extra error reporting:

---------------------------------- common.bas ----------------------------------
index 2117e2d..ff8d336 100644
@@ -1649,10 +1649,12 @@ IF getbinsize(bindex) < curbinsize(bindex) THEN

  IF oldsize > 0 THEN ' Only bother to do this for records of nonzero size

-  DIM tempf AS STRING = tmpdir & "resize" & bindex & ".tmp"
+  DIM tempf AS STRING = lumpf & ".resize.tmp"


The fix I would have wanted to get in is the fix to createnpc, but
it's quite messy.